Giters

juhanakristian / remix-auth-microsoft

Microsoft authentication strategy for remix-auth

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Inconsistent parameters in MicrosoftStrategyOptions

im-neil opened this issue · comments

commented

Why don't the parameters for MicrosoftStrategyOptions in this GitHub repository match those in the npm package?

  1. src/index.ts
    (this repository, version 1.03)

export interface MicrosoftStrategyOptions {
clientId: string;
clientSecret: string;
redirectUri: string;
scope?: string;
tenantId?: string;
prompt?: string;
}

  1. node_modules/remix-auth-microsoft/build/index.d.ts
    (version 1.03 as installed using npm install remix-auth-microsoft remix-auth remix-auth-oauth2 @remix-run/server-runtime)

export interface MicrosoftStrategyOptions {
clientID: string;
clientSecret: string;
callbackURL: string;
scope?: string;
tenant?: string;
prompt?: string;
}

commented

Hi @im-neil and thanks for reporting the issue. The repository does indeed have different parameter names because they are going to be changed in the next version bu package version in the repo hasn't been updated yet. Sorry for the inconvenience.

commented

This has now been resolved in v2.0.0