Turkish I-ı character

Question

Turkish I-ı character

alperenbabagil opened this issue 4 years ago · comments

When taking brand names the code lowercases it with the phone's locale. But it generates a problem in Turkish language devices. For example HUAWEI lowercased as "huaweı" and it is not equal to "huawei" obviously. I think there is no need for the phone's locale when lowercasing because device brand names are all returned in ASCII characters.

Jude Fernandes · Answer 1 · Sat Jul 04 2020 17:24:24 GMT+0800 (China Standard Time)

Thanks for pointing this out @alperenbabagil , I'm a little busy this weekend so if you can create a PR for this I'll be happy to review it.

Alperen Babagil · Answer 2 · Sat Jul 04 2020 19:07:01 GMT+0800 (China Standard Time)

Hi Jude,
I cannot push a new branch

Jude Fernandes · Answer 3 · Sat Jul 04 2020 20:11:21 GMT+0800 (China Standard Time)

Hi Jude,
I cannot push a new branch

Fork & Create a PR

Alperen Babagil · Answer 4 · Sat Jul 04 2020 21:27:02 GMT+0800 (China Standard Time)

Man.. I mean you must allow pushing new branch

Adi-Marian Mutu · Answer 5 · Fri Jul 10 2020 18:28:43 GMT+0800 (China Standard Time)

I've fixed the code in the pull request #46

Jude Fernandes · Answer 6 · Sun Jul 11 2021 02:47:45 GMT+0800 (China Standard Time)

Closing this one since there is no activity