Recent DynamicObject::writeAsJSON() breaking change issue not documented
danra opened this issue · comments
Detailed steps on how to reproduce the bug
Commit 224c4f7 changed DynamicObject::writeAsJSON()'s signature. BREAKING_CHANGES.txt mentions possible issues with overriding classes, but there's also just the issue of having to modify any existing callers that's not mentioned.
Would be nice to either:
- mention that issue as well and show a migration example; or, even better:
- keep the previous overload in place, make it non-virtual, and make it call the new virtual overload. That would actually make the BREAKING_CHANGES.txt complete as is because just consumers won't have to change anything.
What is the expected behaviour?
Operating systems
Other
What versions of the operating systems?
Architectures
Other
Stacktrace
No response
Plug-in formats (if applicable)
No response
Plug-in host applications (DAWs) (if applicable)
No response
Testing on the develop branch
The bug is present on the develop branch
Code of Conduct
- I agree to follow the Code of Conduct
I see this was resolved on develop, thanks!