[Bug]: juceNotificationToNSUserNotification assertion failure on call to varObjectToNSDictionary
danra opened this issue · comments
Detailed steps on how to reproduce the bug
Regression since 42ab540.
PushNotificationsDelegateDetailsOsx::juceNotificationToNSUserNotification unconditionally calls varObjectToNSDictionary (n.properties), but n.properties is documented to be optional and indeed we witnessed it to be isVoid(), causing the new assertion jassert (varToParse.isObject()) at the start of varObjectToNSDictionary to fail.
What is the expected behaviour?
No assertion
Either widen varObjectToNSDictionary's contract to allow isVoid(), or test for isVoid() in juceNotificationToNSUserNotification before calling varObjectToNSDictionary
Operating systems
macOS
What versions of the operating systems?
Architectures
x86_64
Stacktrace
No response
Plug-in formats (if applicable)
No response
Plug-in host applications (DAWs) (if applicable)
No response
Testing on the develop branch
The bug is present on the develop branch
Code of Conduct
- I agree to follow the Code of Conduct
Thanks for reporting @danra we had another report about this too, a fix is working it's way through CI now.
Seems I forgot to close this. Thanks again for reporting this should have been fixed in 4d098fa. Let me know if you face any more issues.