Handle restore

Question

Handle restore

jtpio opened this issue 5 years ago · comments

At the moment the panels are not restored on page refresh.

We could transparently use the LayoutRestorer to transparently restore these panels that are added to the shell.

Jeremy Tuloup · Answer 1 · Fri Feb 28 2020 18:10:24 GMT+0800 (China Standard Time)

Maybe we could use a similar approach as @saulshanabrook did in https://github.com/Quansight-Labs/jupyter-widgets-takeover, instead of relying on the widget's pWidget.

Saul Shanabrook · Answer 2 · Sat Feb 29 2020 00:44:08 GMT+0800 (China Standard Time)

I spoke too soon, unfortunately...

Issue is we don't save the arguments to restorer.restore(tracker, options) anywhere so we have no way of re-restoring widgets later :(

Jeremy Tuloup · Answer 3 · Sat Feb 29 2020 02:13:39 GMT+0800 (China Standard Time)

It sounds like it should be doable, but would maybe require writing a custom widget manager though.

Saul Shanabrook · Answer 4 · Sat Feb 29 2020 02:19:28 GMT+0800 (China Standard Time)

I got this working with my widgets factory... it's a bit zany though: https://github.com/Quansight-Labs/jupyter-widgets-takeover/blob/a0b2af7245e420297784eb9a4338b8f6e2c8747a/src/workspace.tsx#L60-L90

Jeremy Tuloup · Answer 5 · Sat Feb 29 2020 02:49:15 GMT+0800 (China Standard Time)

But it looks functional :)

I guess it would even make sense to be able to remove the chrome in core lab as well.

Jeremy Tuloup · Answer 6 · Sat Feb 29 2020 02:49:43 GMT+0800 (China Standard Time)

Ah I see you posted in jupyterlab/jupyterlab#2031 👍

Saul Shanabrook · Answer 7 · Sat Feb 29 2020 03:07:39 GMT+0800 (China Standard Time)

Yeah it's functional haha after many tears...

Douglas Blank · Answer 8 · Mon Dec 14 2020 03:59:30 GMT+0800 (China Standard Time)

I think this can be closed, now?

Jeremy Tuloup · Answer 9 · Mon Dec 14 2020 19:35:18 GMT+0800 (China Standard Time)

Thanks @dsblank. Yes there is now basic support for this using the widget restoring process.

The next steps could be looking into more advanced layouts like in #48, and be able to restore the layout even if the widgets don't exist on the Python side yet (recreating them from a notebook path).