jtorjo / external_drive_lib

Easily read/write files on Phones/Tablets that connect to your PC via USB. Deal easily with any external drive, even if you can't find it in the available drives (DriveInfo.GetDrives)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Move temporary directory to Temp instead of AppData

fahminlb33 opened this issue · comments

I just tested my refactored code and found out that this library uses AppData folder instead of Temp folder to store temporary files (files being copied, etc; I haven't checked all the code yet, just renaming things).

I think the lib should use Temp directory instead of AppData. If the app forgets to remove old temporary data, let Windows do it using Disk Cleanup or CCleaner. Files on AppData doesn't get cleaned up even with cleaner apps (without some modification, of course). Instead, we should put the temporary files on Temp folder which is intended to store temporary files.

Or, maybe there is something to do why we're storing temporary files inside AppData instead of Temp?

Hi,
Moved into Local\Temp now.

But, please note this: win_util.temporary_root_dir_impl -> I automatically delete old folders.
I was using some temp directory for examples (bulk_copy and such) - but that is just for examples, and moved that into Local\Temp as well.

Long story short, even though the lib auto deletes its old folders, moved into Local\Temp

Best,
John