jthegedus / svelte-adapter-firebase

SvelteKit adapter for Firebase Hosting rewrites to Cloud Functions for a Svelte SSR experience

Home Page:https://github.com/jthegedus/svelte-adapter-firebase

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update `rawBody`

benmccann opened this issue · comments

Describe the Bug

See sveltejs/kit#2215

You'll need to update

const finalRawBody =

This is the last breaking change on the 1.0 milestone affecting SvelteKit adapters, so while no promises, hopefully there won't be any more changes required after this

Thanks for providing this adapter!

Steps to Reproduce

look at source code

Expected Behaviour

uses latest SvelteKit API

svelte-adapter-firebase version

n/a

sveltejs/kit version

latest

will get on this soon, thanks for the report 👍

@benmccann I want to type render from import {init,render} from '../output/server/app.js'; to ensure my adapter matches the correct types, is this possible? I am unsure if App.init and App.render are the correct types and if they can/should be exposed?

Edit: I think I found the type for render with import('@sveltejs/kit/types/internal').Incoming?

Thanks for your help on this 🙏 Hopefully my new rawBody code is correct 😅