Giters

jtblin / aws-mock-metadata

Mock ec2 instance metadata service that can run on a developer machine

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Create package

totallyunknown opened this issue · comments

commented

I think it make sense to make this as a package, so we can use it as a mock for unit testing in kube2iam. What do you think?

commented

I definitely use the docker image to be able to test locally with minikube and we could use it for some kind of end to end tests but I think that would be pretty hard to setup and maintain. I'm looking at increasing unit test coverage first for which I think, I'd just use unit level mocks rather than running aws-mock-metadata. But I'm opened to suggestion, did you have something else in mind?

commented

#10 adds a lot of mocked test coverage, which will get merged sometime shortly.

@totallyunknown can you elaborate on what the testing topology might look like with kube2iam, the way you vision things currently? I can see both sides of the argument (with limited exposure right now), re moving the source code into a subdirectory that can be used as a package, vs using a Docker based aws-mock-metadata to expose the mocks where required.