Feature: Support Nx workspace.json version 2
evanfuture opened this issue · comments
Is there an existing issue for this?
- I have searched the existing issues
Is this a regression?
No
Current behavior
When extracting, the lib tries to find the projectBasePath based on either angular.json or workspace.json configurations. But when using the project.json format with workspace.json version 2, the workspace.json only contains a reference to the path to the project.json, and that file then contains the sourceRoot and projectType.
Essentially, when migrating to this new format, eg with nx generate @nrwl/workspace:convert-to-nx-project --all, the extract command fails.
Expected behavior
Nx workspace version 2 with project specific configs is supported.
Please provide a link to a minimal reproduction of the bug
Not sure how with this...
Transloco Config
No response
Debug Logs
No response
Please provide the environment you discovered this bug in
Transloco:
Transloco Keys Manager:
Angular:
Node:
Package Manager:
OS:Additional context
No response
I would like to make a pull request for this bug
Yes 🚀
i want this feature :(
@EndyKaufman Once the comments are fixed I'll merge & release ASAP
@EndyKaufman Can you please verify v3.3.0?
i try
@shaharkazaz
not work, example repo https://github.com/EndyKaufman/new-nx-with-transloco-keys-manager
@EndyKaufman Found the issue, please check 3.3.1, add a test for this case as well 👍
cool!!!!!
extract work in this sample
I don't use find but ran for test and got error
@EndyKaufman The issue is with your transloco config, the Translations path shouldn't be absolute, it's relative to the src.
Change it to assets/i18n and it will work