Giters

jsta / wql

Water Quality - Lite : Exploring Water Quality Monitoring Data

Home Page:https://jsta.github.io/wql

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

eof/prcomp scale argument is hardcoded

troyhill opened this issue · comments

commented

I noticed that the scale. argument passed to wql::eof is not used in the function. I think that argument is intended to be used on line 89, but the scale argument in the prcomp call is hard-coded as TRUE (pr1 <- prcomp(x, scale.=TRUE)) instead of pr1 <- prcomp(x, scale.=scale.)

Thank you for the excellent package.