jssor / slider

Touch swipe image slider/slideshow/gallery/carousel/banner mobile responsive bootstrap

Home Page:https://www.jssor.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

jssor fails tests because its still using non-passive Event Listeners

opened this issue · comments

Hi,

You need to make all your scrolling event listeners 'passive' this has been the rule of thumb for several years now.

For more info you can see the following info links:

https://developers.google.com/web/tools/lighthouse/audits/passive-event-listeners

Google dev dated 2016: https://developers.google.com/web/updates/2016/06/passive-event-listeners

Please can you update them to be all set to passive!

The problem can be shown in this video: https://www.youtube.com/watch?v=65VMej8n23A

Thanks.

commented

not ready for some browsers yet, will change later

commented

@jssor

Can you add this now? Browser support is very good.

image

Only IE11 is an issue, don't care about Malware chinese browsers.

Chrome error with v28.0.0

[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

Note: Other slider libraries like slick use passive events.