BOOL are mapped to 1 and 0 instead of true and false

[Adam Różyński]

JSONModel 1.8.0

All BOOL properties are now mapped as a number instead of JS boolean. It can potentially break a lot of the existing code (like mine <3).

[James Billingham]

Unfortunately this is a pretty difficult problem - I believe there are a few property type encodings which are ambiguous. Probably relates to one of the recent PRs

[James Billingham]

I imagine relates to #569

If you can do a PR to fix, I’d be happy to get it pushed. Please make sure you include regression tests which fail with the current code and pass with your fix.

[Barry Stump]

In our project, I've narrowed it down to e2c3421

[Barry Stump]

This appears to be Mac OS-specific. I have a tiny reproducible case which passes when run under iOS tests, but fails under Mac OS tests.

// simple test object
@interface BoolTestObject : JSONModel
@property (nonatomic, assign) BOOL isAwesome;
@property (nonatomic, assign) BOOL isTerrible;
@end

@implementation BoolTestObject
@end

// https://github.com/jsonmodel/jsonmodel/issues/625
- (void) testBoolToJson {
	BoolTestObject *b = [[BoolTestObject alloc] init];
	b.isAwesome = YES;
	b.isTerrible = NO;

	NSString *expected = @"{\"isAwesome\":true,\"isTerrible\":false}";
	NSString *json = [b toJSONString];
	XCTAssertEqualObjects(expected, json); // fails on Mac OS
}

[Chase]

I am having this problem on iOS versions <= iOS 10

[James Billingham]

Feel free to PR.