jsmrcaga / action-netlify-deploy

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

netlify.toml different from build files upon deployment

mkukawski opened this issue · comments

Hi I started seeing strange problem since week ago in our github deployments when using your package.
It seem to be sort of regression somewhere but I'm not sure if it is on netlify side or this code or netlify CLI is doing something to tinker netlify.toml file...
Context:

  • We supply netlify.toml file together with build files in top directory - I put it in .zip file here as "netlify_on_github_action.toml" for you to easy understand.

  • On netlify side we don't see file being applied, when checking deployment files there is netlify.toml file but with different content, which causes issues. I put it in .zip file here as "netlify_on_netlify_side.toml"

netlify_files.zip

Our github action workflow file is more less like that (trimmed a bit for readability and privacy) as below.

jobs:
build-and-deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
- uses: jsmrcaga/action-netlify-deploy@v2.1.0
with:
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_TOKEN }}
NETLIFY_SITE_ID: ${{ inputs.SITE_ID }}
build_directory: ./bonny/dist
build_command: "echo Skipping building the web files"
install_command: "echo Skipping install"
NETLIFY_DEPLOY_TO_PROD: true
- name: Save netlify.toml as artifact after deploy
uses: actions/upload-artifact@v3
with:
name: build-afterdeploy.toml
path: ./bonny/dist/netlify.toml

This was always working for 2 years now, we didn't touch this for long time. It suddenly started failing since last week.
I saw in your code you use some sort of CLI command in the script, but it's not very clear where it comes from, I maybe missed this, but I dont see any explicit installaction of the netlify CLI...
Could you triage if this issue is on your side or github or netlify ? What you think ?
I asked netlify support they say they don't tinker with netlify.toml files but not sure to trust that...

Thanks

root cause is netlify cli
netlify/cli#6190