Some users expect MIT to appear earlier than MIT-*
jeffmcaffer opened this issue · comments
in https://github.com/shinnn/spdx-license-ids/blob/master/index.json the license ids appear to be sorted alphabetically however the MIT entry is not first in the MIT* family of ids. It would just be handy if they were already sorted.
This library just uses the data fetched from https://spdx.org/licenses/licenses.json and we don't sort results by ourselves. If you have any complaints against the order of the original license list, ask SPDX Workgroup about it instead.
Strongly recommend that code using this module do its own .sort() if it needs predictable order.
What I mean is, https://github.com/spdx/license-list-data/ is actually updated, congraturations. But https://spdx.org/licenses/ is not.
@kemitchell Do you really think so though spdx/tools@7c4a67f is introduced.
@shinnn I wouldn't make the sorting behavior of a website part of the API of the spdx-license-ids package. Sorting costs very little in performance. Even if performance is a concern, users can always sort in a build step, before runtime.
@shinnn If you really want sorted data, I suggest you do it in your build step. Sort in build.js, in some deterministic, platform-independent way. Publish that sorted data file to npm.
@shinnn I think that's fine. Let downstream users sort or otherwise post-process if they need to.