If-Modified-Since is not ignored if request contains If-None-Match

Question

If-Modified-Since is not ignored if request contains If-None-Match

marco2216 opened this issue a year ago · comments

According to the latest HTTP RFC,

A recipient MUST ignore If-Modified-Since if the request contains an If-None-Match header field; the condition in If-None-Match is considered to be a more accurate replacement for the condition in If-Modified-Since, and the two are only combined for the sake of interoperating with older intermediaries that might not implement If-None-Match.

fresh does not ignore If-Modified-Since, it returns false if the If-Modified-Since is before last-modified. I would expect it to return true immediately if If-None-Match matches the ETag header.

Douglas Wilson · Answer 1 · Tue Jan 31 2023 21:33:00 GMT+0800 (China Standard Time)

Ah, yes, it looks like this is a new change in the spec, as that requirement was not part of RFC 7232, AFAICT.

Marco Sylvestersen · Answer 2 · Tue Jan 31 2023 21:35:01 GMT+0800 (China Standard Time)

I think it was?

Douglas Wilson · Answer 3 · Tue Jan 31 2023 21:36:16 GMT+0800 (China Standard Time)

Oh, you're right. That's why I said as far as I can tell. I guess I assumed it would be in the same section in both RFC, doh.

Marco Sylvestersen · Answer 4 · Wed Feb 01 2023 00:35:11 GMT+0800 (China Standard Time)

If you'd like, I could try to create a PR addressing the issue?

Douglas Wilson · Answer 5 · Wed Feb 01 2023 00:50:03 GMT+0800 (China Standard Time)

Hi @marco2216 you can, though sorry I didn't post yet, just before you go through too much trouble, I did already start on the develop branch a couple hours ago. I just noticed that I need to switch the project over to GH Actions to finish it off, and will just need to wait until after I'm done with work today to work on that since it's more involved.

Marco Sylvestersen · Answer 6 · Wed Feb 01 2023 02:24:32 GMT+0800 (China Standard Time)

Oh I see, I'll let you handle it then 👌

ryanwang · Answer 7 · Mon Apr 10 2023 19:11:51 GMT+0800 (China Standard Time)

Hi, sorry to bother you. May I ask if there has been any progress on this matter, or what the follow-up plan is, or if there is a timeline? @dougwilson

Douglas Wilson · Answer 8 · Mon Apr 10 2023 23:41:20 GMT+0800 (China Standard Time)

Hi @bigbigDreamer apologies for that! It just got lost in the sea of notifications for me and then fell off more as I got some unrelated security reports I had to triage and working on fixing one of them currently. I think I already pushed up the changeset, so I will get a release made and pushed here.

Ulises Gascón · Answer 9 · Mon Apr 29 2024 15:35:39 GMT+0800 (China Standard Time)

If you'd like, I could try to create a PR addressing the issue?

Hi @marco2216! Are you still interested in working on this PR? We've completed the migration to GitHub already :)

ryanwang · Answer 10 · Tue Apr 30 2024 01:08:51 GMT+0800 (China Standard Time)

If you'd like, I could try to create a PR addressing the issue?

Hi @marco2216! Are you still interested in working on this PR? We've completed the migration to GitHub already :)

Hi @UlisesGascon , I fix this, can u help me review #38

All tests passed!