optionally include all the headers

Question

optionally include all the headers

jonathanong opened this issue 10 years ago · comments

http://en.wikipedia.org/wiki/HTTP_ETag#Strong_and_weak_validation

according to the wiki, strong etags mean that the entity headers are unchanged as well. we should optionally allow users include these headers and apply them into the hash

Douglas Wilson · Answer 1 · Fri Jun 05 2015 10:59:03 GMT+0800 (China Standard Time)

I was just looking into this to see what a good way would be; I'm trying to decide the following things:

Should it just be dump & simple by just taking into consideration all Content-* headers?
Should the Content-Length being there vs. absent make a difference?
Should Content-Range be taken into consideration?
Should Content-Encoding be taken into consideration?
Is it even worth it?

jongleberry · Answer 2 · Fri Jun 05 2015 11:06:01 GMT+0800 (China Standard Time)

i'm not sure... to me, these extra headers are only relevant if we don't take a sha of the entire body. if we do a sha of the body, we shouldn't need to include these headers in the etag calculation.

Douglas Wilson · Answer 3 · Fri Jun 05 2015 11:08:56 GMT+0800 (China Standard Time)

SGTM; as of the current master (and thus 2.0) we will always take a MD5 and include length outside the hash for length extensions. That should pretty much guarantee what we need. The only real header that seems useful to consider is Content-Type.