Any chance of an update?

Question

Any chance of an update?

humblecoder opened this issue 6 years ago · comments

Any chance of an update? As of this post, Leaflet is on 1.4.0 and doesn't seem to properly load/initialize with this plugin.

James Seppi · Answer 1 · Wed Jan 30 2019 22:44:26 GMT+0800 (China Standard Time)

Hey @humblecoder - are you seeing an error of some sort?

I've updated the example index.html (see 0e7e043) to use Leaflet 1.4.0 and changed the example basemap to one offered by carto.com since the previous MapQuest service is now gone.

Everything looks like it still works to me, and I didn't have to make any changes to Leaflet.MakiMarkers.js.

Michael W · Answer 2 · Thu Jan 31 2019 02:42:54 GMT+0800 (China Standard Time)

@jseppi Thanks. I'm using VueJS and including the plugin via imports which should have been just fine. I was getting errors of L being undefined. I shuffled the code a bit and all is well. Now, however, I'm having an issue with some of the icons. Apparently not all in the list are valid. Any links to updated icon names?

James Seppi · Answer 3 · Thu Jan 31 2019 04:44:51 GMT+0800 (China Standard Time)

I think the marker names given by https://github.com/mapbox/maki/blob/v0.5.0/_includes/maki.json should all be valid.

Michael W · Answer 4 · Fri Feb 01 2019 07:53:12 GMT+0800 (China Standard Time)

Thanks, those seem to work!