jscissr / react-polymer

Use Polymer elements in React

Home Page:https://jscissr.github.io/react-polymer/demo/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

What would it take to support React 0.14??

kristianmandrup opened this issue · comments

https://facebook.github.io/react/blog/2015/09/10/react-v0.14-rc1.html

Just curious... Would love to help making support for remaining core polymer elements ;)

This module does a lot of monkey patching, and because react-dom is now a seperate package I guess some require()s have to be changed.

In React DOM, arbitrary attributes are supported on custom elements (those with a hyphen in the tag name or an is="..." attribute).

This sounds like great news 😎, ...but it doesn't work as soon as you have custom attributes on standard elements (<div drawer></div>) 😞 .
The only advantage is that reactPolymer.registerAttribute needs only to be called for this case.

There are likely other internal changes in React which break react-polymer.
I didn't look into the code yet, I think I will when 0.14 is released. But of course you can already try yourself 😃

I'm working on it. :)

React 0.14 now supported!