2gb Image limitation for gamelists

Question

2gb Image limitation for gamelists

PittStone opened this issue 6 years ago · comments

The limitation of the image files is the real problem. Images over 2gb are not showing in Emulationstation with Infos, Pictures and Videos. Only the file itself is showing and the game starts normaly, but without the Infos from the gamelist.

eduyano · Answer 1 · Fri May 25 2018 03:25:01 GMT+0800 (China Standard Time)

I have the same problem with roms/isos over 2GB

eduyano · Answer 2 · Fri May 25 2018 03:26:21 GMT+0800 (China Standard Time)

During the initialization when parsing the gamelist these roms are ignored

Ben Baron · Answer 3 · Sun Jun 03 2018 01:14:50 GMT+0800 (China Standard Time)

Just ran into this bug today. Can confirm it seems to happen only with roms over 2gb. For example, most of my PS2 collection.

Ben Baron · Answer 4 · Sun Jun 03 2018 01:45:28 GMT+0800 (China Standard Time)

Looking into this now. The bug appears to be with the call to Utils::FileSystem::exists() in es-app/src/Gamelist.cpp line 115. The actual method is located in es-core/src/utils/FileSystemUtil.cpp line 553.

The actual bug appears to be the use of stat to get the file info. Surprise surprise, stat only supports files up to 2GB. There's another call, stat64, that supports larger files!

I found an answer here that indicates that it should be trivial to replace and will work in Windows: https://stackoverflow.com/a/18574629/299262

I assume no one has noticed this in RetroPie as it's less common to emulate anything newer than the original playstation, maybe a little N64 if you overclock.

I'm going to try the fix now and will make a PR if it works.

Ben Baron · Answer 5 · Sun Jun 03 2018 07:26:27 GMT+0800 (China Standard Time)

So it took me about 5 minutes to try out the fix and compile on Linux...and the rest of the day to try and get compiling working on Windows FML. I think I'm almost there though. Hoping to have a PR in today. There's no real reason this solution won't fix the problem, the only potential issues could be incompatibilities with Windows, because Windows is "special", but even that shouldn't be insurmountable.

Ben Baron · Answer 6 · Sun Jun 03 2018 12:50:13 GMT+0800 (China Standard Time)

Fixed it! Took all of 10 minutes to fix, then 8 hours getting EmulationStation compiling on Windows haha. But having it work perfectly the first compile and seeing all of the metadata for my PS2 games was worth the pain!

Pull request here: #14

Ben Baron · Answer 7 · Sun Jun 03 2018 12:51:12 GMT+0800 (China Standard Time)

Looking forward to contributing more now that the painful "just get it to build" phase is over.

eduyano · Answer 8 · Fri Jun 15 2018 19:40:44 GMT+0800 (China Standard Time)

well, issues or requests from this release, will never get commited....
just from retropie

Ben Baron · Answer 9 · Tue Jun 19 2018 10:22:47 GMT+0800 (China Standard Time)

@eduyano good to know, in that case I'll fork RetroPie and submit the PR there.

John Rassa · Answer 10 · Mon Jun 25 2018 10:46:43 GMT+0800 (China Standard Time)

@einsteinx2 sorry I didn't notice this or #14 earlier. I didn't have notifications enabled as I didn't expect anyone to create tickets or PRs here. This fork is primarily my working repo and all work I do is added to the RetroPie repo. Please create a PR in RetroPie and it will get reviewed there.

goyetus · Answer 11 · Mon Jul 30 2018 08:04:45 GMT+0800 (China Standard Time)

@einsteinx2 Do you have any windows compiled version? Im not a c++ dev , and is a terrible pain to try to compile by myself..... could you help me?

Is there any Windows version Fixed with the 2gb problem? I cannot find any binary , and I dont know anything about compile......

I saw the code, using stat64 as fix, but i dont know how to compile....

Do you have any compiled version? Thanks a lot!!!