Reconsolidate with Wikimedia fork
Krinkle opened this issue · comments
I forked this plugin in 2011 within the wikimedia/mediawiki repository (wikimedia/mediawiki@83a7822df7b).
Current files:
- src/jquery.colorUtil.js
- src/jquery.color.js
- test/qunit/jquery.color.test.js
- test/qunit/jquery.colorUtil.test.js
I would love to reconsolidate with upstream.
The fork also has fairly elaborate QUnit tests (using latest version of QUnit) which may be useful. Ping issue #69.
The main repo has added a ton of functionality since then. Is there anything in the Wikimedia fork that doesn't already exist at this point?
@raphamorim do you wanna check this in?
Ok, leave it to me.
@leobalter @Krinkle I checked the differences, but the jquery-color evolved a lot since 2011. Resulting a huge change in the main repo.
I believe that the best way would be to specify features they would like to be added.
We can do this at least from the tests. This way we guarantee a great use
case (Wikimedia).
It's worth the complexity. :)
On Wednesday, October 26, 2016, Raphael Amorim notifications@github.com
wrote:
@leobalter https://github.com/leobalter @Krinkle
https://github.com/Krinkle I checked the differences, but the
jquery-color evolved a lot since 2011. Which results a huge change in
main repo.I believe that the best way would be to specify features they would like
to be added.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#85 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASYkc44VNKwe7WSYRmBm3aBpEHYZYTlks5q3-RzgaJpZM4GxLzt
.
This thread has stalled. Let's open a separate issue for each individual feature, if there still are any.