jquery / jquery-color

jQuery plugin for color manipulation and animation support.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

won't work with jQuery 1.7 (isNan now isNumeric)

jasonwilliams opened this issue · comments

Line 161 of the current version needs changing from

if ( value == null || isNaN( value ) ) {

to

if ( value == null || !isNumeric( value ) ) {

this should solve the problem.
the only problem is this won't work on < jQuery 1.7

isNaN is a built in function of JavaScript and is different than what $.isNaN and $.isNumeric is. This shouldn't have any problems, regardless of jQuery version since it's not utilizing the jQuery numeric functions.

Also, all of jquery-color's tests pass on jQuery 1.7 - have you ran into issues with 1.7?

Dan that is true although this is using jQuery's isNaN not the native
javascript function which is why it breaks.

Try it yourself.

http://bugs.jquery.com/ticket/10478

dan

hmm weird, I've just checked and I think im running a version different to the one on here.
I will have to try it again with the latest.

@Jayflux, yeah - Corey already fixed it a while ago: 4a6abaf