jquery / jquery-color

jQuery plugin for color manipulation and animation support.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Merge the new Color Plugin with xColor

infusion opened this issue · comments

I pulled my xColor plugin to become the new jQuery Color plugin some time ago, which got rejected for no real reason. The new Color-plugin implements a few methods, I've already implemented with my plugin and I would suggest a merging of both libraries to build a new library, which implements all necessary features. I would be glad to contribute all features, because I don't want to maintain the library for my own over a long time.
For all, who don't know my xColor-plugin, please take a look at my examples page on http://www.xarg.org/project/jquery-color-plugin-xcolor/
I like the way you've implemented the way to "skip" colors with "null". I would keep this feature.
I thought about jQuery.Color( element, cssProperty ); too, but didn't implemented it because I rather implemented specialized methods like isReadable() and so on, but I would keep this, too.
I think the biggest difference between both libs is that the Color-plugin uses it's constructur to have a source-color for every calculation. A previsous version of xColor had this feature, too, but I wanted to keep the functionality at every individual calculation-method, in order to have more liberty with the design decisions of further color-methods.
I must admit, my library tries to implement many color methods and isn't really extensable. The way you do it with jQuery.Color.fn is really cool and more jQ-ish. I would keep this feature, or better said, I would use it for the base of the whole method-set. I would remove my complete xColorMix() object (which results in $.xcolor) and keep all methods as extension (in a seperate js file). The library in itself is thus small and powerful at parsing colors, build a hook for color calculation methods and animating colors.
My proposal would be: We use my internal xColor() function/object instead of your color()-function to parse colors and extend it to work with optional numbers. Additionally, we throw away my internal xColorMix() object and add all methods via the external interface.
I would be glad to see my $.each() implementation in the official plugin, too. It's much more optimized and allows to loop over a list of colors very efficiently.
I spend generally a vast number of hours to optimize my library and test it against several scenarious. As I said, I would be glad to merge both libraries to build one uniform library for this kind of job.
Robert

Thanks for your interest in contributing to $.Color.

If you see improvements that you could make in the current library, please submit pull requests so we can review the changes.

As far as new features / functions go - If you have features you want to add, please give us a proposal for an API for these features / potentially a pull request with these features.

Closing for vagueness and lack of activity. Feel free to create issues for specific improvements.