inaccessible messages included in unread count

Question

haliphax opened this issue 9 years ago · comments

When showing the count of unread messages, private messages to other users (which the message reader will not show) are included in the total.

Additionally, using 'm' to 'mark all as read' when there are (public) unread messages brings the unread count to 0.

Jeff Quast · Answer 1 · Tue Feb 17 2015 11:52:01 GMT+0800 (China Standard Time)

code is

Jeff Quast · Answer 2 · Tue Feb 17 2015 11:56:07 GMT+0800 (China Standard Time)

try moving all_private = list_privmsgs(None) to line 143,
then deleting lines 155, 156,

messages['new'] -= all_private
messages['all'] -= all_private

then changing all occurrences of .update(msg_indicies) to .update(msg_indicies - all_private)

haliphax · Answer 3 · Tue Feb 17 2015 22:08:06 GMT+0800 (China Standard Time)

I'll give that a shot this week.

haliphax · Answer 4 · Tue Mar 10 2015 01:08:33 GMT+0800 (China Standard Time)

Looks like that fix does work. I'm going to ride it out for a day or two and then send a PR.

haliphax · Answer 5 · Thu Mar 12 2015 07:45:19 GMT+0800 (China Standard Time)

Hmmm... well, my own unread private messages are no longer included in the count. I'll tweak that and test again.

Jeff Quast · Answer 6 · Tue Apr 28 2015 08:06:18 GMT+0800 (China Standard Time)

tags may also have to be filtered away. I have tags for messages I can't read.