Deep Linking Scroll

Question

Deep Linking Scroll

DavieReid opened this issue a year ago · comments

When you navigate to a section on a page and that page is using the Table of Contents (TOC) component the following happens:

Actual

the page is briefly at the section linked
the page scrolls to the top
first section in the TOC is highlighted
you are now lost and need to scroll back down the page to find the linked section (if you even know what it is)

Expected

The linked section is highlighted in the TOC
The linked section is in view (at the top of the page if the page is long enough to do so)

lilyvc · Answer 1 · Tue Apr 11 2023 23:29:08 GMT+0800 (China Standard Time)

Is this still an issue? I can't recreate it

Davie · Answer 2 · Wed Apr 12 2023 17:31:17 GMT+0800 (China Standard Time)

The scolling to the top issue doesnt seem to be there anymore but its still not great.

Try this link --> https://mosaic-mosaic-dev-team.vercel.app/mosaic/author/refs#existing-refs

are you at the Existing Refs section?

lilyvc · Answer 3 · Mon Apr 17 2023 16:57:20 GMT+0800 (China Standard Time)

Okay I had a look at this and couldn't figure it out. It loads on the correct section and then scrolls to some other part, but there aren't any instances of window.scroll in our code that could be causing it.

Davie · Answer 4 · Mon Apr 17 2023 18:30:30 GMT+0800 (China Standard Time)

if you go to the page (https://mosaic-mosaic-dev-team.vercel.app/mosaic/author/refs) and scroll all the way to the bottom while observing the TOC, you should see existing refs is a heading that never gets highlighted. Maybe that's the root cause...