jpmorganchase / modular

A modular front end development framework

Home Page:https://modular.js.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update esbuild dependancy to support new typescript features

el-dav opened this issue · comments

When I create a new modular project I'm unable to use the satisfies typescript operator, getting an error when I run the project. This remains the case even when I update the typescript version in the root package.json.

I believe this is due to the version of esbuild modular is using. esbuild added this feature in v0.15.13. Adding an esbuild resolution fixes the issue for me.

Maybe worth updating esbuild version to v0.17.5 which supports upcoming typescript 5.0 features such as const type parameters.

@el-dav this should be resolved in 4.3.0 (release imminent now released), we upgraded esbuild to 0.17.14 here