jpmorganchase / modular

A modular front end development framework

Home Page:https://modular.js.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Modular lacks some nice to haves for library publishers

joshwooding opened this issue · comments

Building

  • Auto-including license files (#2050 )
  • Auto-adding the repository field in the package.json (#2161 )

I discovered this when checking out socket https://socket.dev/npm/package/modular-scripts

You can see that modular is flagged because;

  • No matching license files were found
  • No linked source code repositories were found

Shipping the License sounds ideal since that is what contains the copyright notice.
Attaching source code repositories allows features like npm's linking to work e.g.

image

Which is missing for modular:

image

All these problems could be solved manually but it would be nice if the solutions were built directly into modular so it is automatically handled and improves best practices.

The two PRs have been merged, closing