jpmonette / feed

A RSS, Atom and JSON Feed generator for Node.js, making content syndication simple and intuitive! 🚀

Home Page:https://github.com/jpmonette/feed

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

adding attribute type="image/*" to enclosure tags

kedarguy opened this issue · comments

Is your feature request related to a problem? Please describe.
Same problem as this issue and opening a new issue due to this comment

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

when checking the xml output with a feed validator I get an error that the type attribute is required. + feedly requires the type in order to render images

Describe the solution you'd like

Add option to add type attribute to enclosure tags or automatically add type according to the file type

I see that there is already a pull request with a solution

Is there an estimate if it will get merged soon?

adding an image to the feed makes my feed incorrect and is no longer valid. I see this concern was already mentionned here. will the solution be merge soon ?

hi. When i create tag image

           image: {
              link: "http://example.com/",
              title:"example",
              uri:"http://example.com/"
           },

In rss i get:

     <image>
            <title>Институт.Новости: Институт</title>
            <url>[object Object]</url> 
            <link>https://news.yandex.ru/culture.html?from=rss</link>
        </image>

How i can change url for image ?

I think the MIMEtype should be added, see spec:
https://cyber.harvard.edu/rss/rss.html#ltenclosuregtSubelementOfLtitemgt

Still not fixed. Currently the output of RSS v2.0 is:

<enclosure url="https://some_thumbnails.com/bla/bl"/>

Great DX so far, just hit this issue myself... The <enclosure> tag apparently has three required attributes

<enclosure> sub-element of <item>
<enclosure> is an optional sub-element of <item>.
It has three required attributes. url says where the enclosure is located, length says how big it is in bytes, and type says what its type is, a standard MIME type.
The url must be an http url.
<enclosure url="http://www.scripting.com/mp3s/weatherReportSuite.mp3" length="12216320" type="audio/mpeg" />

Any chance of this being added?

Please consider to add this feature. See example here - https://about.flipboard.com/rss-spec

I made the tweak and can send a PR if so desired:

https://github.com/loganpowell/rss2

I'm bumping this issue thread again. I strongly recommend that this project fully implement the RSS2 specification.

Hopefully this will sort it #120

does anyone know of a validator to integrate into tests ?
I had a look at https://github.com/andre487/feed-validator but I am not overly confident this will do it as it seems to be coming with quite a footprint for a test utility.