Antialias and a couple of comments
romainpiel opened this issue · comments
Hey,
Good job mate for this library! A couple of comments there:
- you should set the antialias to the paints, I've tried and it looks better
- I'm not sure if inheriting from ProgressBar is a good idea. You are doing some extra work in your
super.onDraw(canvas)I would actually clone the code fromProgressBar, remove what I don't need and set that as a base class for my custom progress bars.
Good idea anyway!
Thanks good idea both of them. It's true I've been a bit lazy calling super. As soon as I find some spare time I do it, commit and I comment back here.
Cool, I'm moving your code to a custom drawable it makes more sense. Will send a pull request later on.