Reviews lost when rebasing from master
bahamat opened this issue · comments
Brianna Bennett commented
How to reproduce
-
make change
-
submit cr
-
someone reviews
-
someone approves
-
Somewhere along the way, another change has already been merged upstream and now cannot fast-forward
-
Run...
git checkout master git pull git checkout $oldbranch git rebase master grr
Note, that grr
was not run between IA and rebasing. This causes gerrit to consider this a "non-trivial" change, and wipes out the reviews/aproval.