path module is now in spork
uvtc opened this issue · comments
Just did jpm install joy and I see that it pulls in /usr/local/lib/janet/path.janet, but path already comes with spork now (/usr/local/lib/janet/spork/path.janet).
Hm. I see this in my console after installing joy:
cloning repository https://github.com/pyrmont/musty to /usr/local/lib/janet/.cache/https___github.com_pyrmont_musty
Cloning into '/usr/local/lib/janet/.cache/https___github.com_pyrmont_musty'...
remote: Enumerating objects: 140, done.
remote: Counting objects: 100% (140/140), done.
remote: Compressing objects: 100% (51/51), done.
remote: Total 140 (delta 62), reused 135 (delta 57), pack-reused 0
Receiving objects: 100% (140/140), 32.96 KiB | 8.24 MiB/s, done.
Resolving deltas: 100% (62/62), done.
HEAD is now at e1a8219 Remove unnecessary include of spork module
cloning repository https://github.com/janet-lang/spork to /usr/local/lib/janet/.cache/https___github.com_janet-lang_spork
Cloning into '/usr/local/lib/janet/.cache/https___github.com_janet-lang_spork'...
remote: Enumerating objects: 99, done.
remote: Counting objects: 100% (99/99), done.
remote: Compressing objects: 100% (79/79), done.
remote: Total 371 (delta 55), reused 53 (delta 20), pack-reused 272
Receiving objects: 100% (371/371), 82.66 KiB | 3.31 MiB/s, done.
Resolving deltas: 100% (215/215), done.
no dependencies found
removing /usr/local/lib/janet/spork
removing manifest /usr/local/lib/janet/.manifests/spork.jdn
Uninstalled.
generating /usr/local/lib/janet/.manifests/spork.jdn...
Installed as 'spork'.
copying spork to /usr/local/lib/janet...
Does it uninstall spork and then install it again?
And then yet further down in the output I see:
From https://github.com/janet-lang/path
* branch master -> FETCH_HEAD
Updating 0ae7b60..fd552e8
Fast-forward
path.janet | 20 ++++++++++++++++++--
test/suite0.janet | 14 +++++++++++---
2 files changed, 29 insertions(+), 5 deletions(-)
no dependencies found
removing /usr/local/lib/janet/path.janet
removing manifest /usr/local/lib/janet/.manifests/path.jdn
Uninstalled.
generating /usr/local/lib/janet/.manifests/path.jdn...
Installed as 'path'.
copying path.janet to /usr/local/lib/janet...
That is interesting, I wonder if it would make sense to add spork to joy 🤔
If a Janet user creating or running apps or webapps, then I think it's very likely they already have spork installed.
For Janet apps/webapps, I'd be slightly surprised to not see spork in the dependencies.