joule-labs / joule-extension

Lightning payments extension for Chrome

makeInvoice contradicts itself

Technifocal opened this issue 5 years ago · comments

Nicholas commented 5 years ago

Description of the Issue

makeInvoice() contradicts itself, it states the value is both in seconds and hours

Steps to Reproduce

makeInvoice()

Console Logs / Screenshots

See above, here is the line that needs changing (I believe).

Umar Bolatov commented 5 years ago

This seems to have been fixed in the develop branch here: https://github.com/joule-labs/joule-extension/blob/develop/src/app/prompts/invoice.tsx#L183

Will O'Beirne commented 5 years ago

Right you are. Should have a new release out soon with that in it.