Attach: some characters can fail the marking of old patches as obsolete
tuxayo opened this issue · comments
This was obviously caused by the commit message:
Fix typo: unformating → unformatting
There might be other more relevant chars that we might want to accept in commit messages.
Still much of a priority though.
Logs
~/d/koha ❯❯❯ git-bz attach 12310 "HEAD~6..HEAD"
Bug 12310 - Decimal separators issues in patrons payments/fines
4db2944 Bug 12310: Decimal separator issues: fixes in fines
5845e81 Bug 12310: (follow-up) Keep the example text in fines
241a260 Bug 12310: (QA follow-up) Prevent updatedatabase noise
b3de620 Bug 12310: (follow-up) Fix forgotten writeoff amount field
93c4f1c Bug 12310: (QA follow-up) Fix typo: unformating → unformatting
09edbb7 Bug 12310: (follow-up) Complete DecimalSeparators syspref description
Attach? [yn] y
Attached Bug-12310-Decimal-separator-issues-fixes-in-fines.patch
Attached Bug-12310-follow-up-Keep-the-example-text-in-fines.patch
Attached Bug-12310-QA-follow-up-Prevent-updatedatabase-nois.patch
Attached Bug-12310-follow-up-Fix-forgotten-writeoff-amount-.patch
/usr/local/bin/git-bz:1943: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
if attachment.description == commit.subject:
Attached Bug-12310-QA-follow-up-Fix-typo-unformating--unfor.patch
Attached Bug-12310-follow-up-Complete-DecimalSeparators-sys.patch