joshyattridge / smart-money-concepts

Discover our Python package designed for algorithmic trading. It brings ICT's smart money concepts to Python, offering a range of indicators for your trading strategies.

Home Page:https://pypi.org/project/smartmoneyconcepts/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

daylight savings shifts are out of sync

m4rk-lewis opened this issue · comments

for the sessions function, it would be better to specify the open and close time natively to the timezone that we are targeting using the pytz format. eg:

smc.sessions(df, 'New York', '09:30', '16:00', timezone= "America/New_York")

This is because the daylight savings shifts for each country is not in sync, which means that twice a year, there will be several weeks where New York is in daylight savings, but London isn't or vice versa. The same can be said of other timezones.

M