Allow using sessionStorage

Question

Allow using sessionStorage

janosh opened this issue 2 years ago · comments

Janosh Riebesell commented 2 years ago

Could the Storage object be made configurable? Need to store something to sessionStorage instead of localStorage.

Joshua Nussbaum · Answer 1 · Sat Oct 08 2022 09:32:16 GMT+0800 (China Standard Time)

I believe the API for both are similar, so I'd be open to accepting a PR.

Though I wonder if the repo name should change then.

Janosh Riebesell · Answer 2 · Sat Oct 08 2022 10:11:56 GMT+0800 (China Standard Time)

The API is indeed identical afaik. The only difference is sessionStorage is cleared when the page session ends.

Though I wonder if the repo name should change then.

GH automatically sets up URL forward so changing the repo name would be easy. NPM is a problem though.

Joshua Nussbaum · Answer 3 · Sat Oct 08 2022 12:12:55 GMT+0800 (China Standard Time)

Could always add a deprecation warning post-install, if the package name changes.

…

On Fri, Oct 7, 2022, 10:12 p.m. Janosh Riebesell ***@***.***> wrote: The API is indeed identical afaik. The only difference is sessionStorage is cleared when the page session ends. Though I wonder if the repo name should change then. GH automatically setups up URL forward so changing the repo name would be easy. NPM is a problem though. — Reply to this email directly, view it on GitHub <#111 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABCVOMMXZ26L45L3BLNCTWCDJ7NANCNFSM6AAAAAARAASD4E> . You are receiving this because you commented.Message ID: ***@***.***>