joshbuchea / HEAD

A simple guide to HTML <head> elements

Home Page:https://htmlhead.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Meta viewport is not same as mentioned version by bootstrap.

dehghani-mehdi opened this issue · comments

Hi,

Your version of meta viewport (<meta name="viewport" content="width=device-width, initial-scale=1">) is not same as mentioned version in bootstrap docs (<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">).

I'm wondering which one is better option?

Thanks @willpower232

@dehghani-mehdi if you read the discussion in #198 we opted to remove it because:

shrink-to-fit=no became irrelevant during the iOS 9.3 lifecyle and beyond

I am curious to know why it's still included in the Bootstrap docs, because it looks there was a discussion and ultimately it was removed from the project.

I tried poking around for the current 4.4 docs, but didn't find them in the few minutes I spent searching. The latest version of docs in the bootstrap repo is 4.3. If anyone can find the current docs, we can open up a PR.

In v4-dev branch, the viewport still is same as website. I don't know if it is the right file or not tho.

@dehghani-mehdi I'm not 100%, but that looks like the correct branch 👍

This is a good opportunity for someone to open a PR on the bootstrap repo. If no one gets around to it after a bit, I'll probably open up a PR when I have some free time.

v4-dev branch supported and supports those old iOS devices.

Bootstrap team removed shrink-to-fit=no part in their v5's doc, so no need to do anything for this issue anymore.