Some affixes are incorrectly detected / displayed.
imm0r opened this issue · comments
@josdemmers First of all nice idea and pretty good job so far! I have found some minor issues and wanted to let you know.
- When ever you activate stats like damage because you want to track +Damage % you will also get positiv results for stats like "damage with xy". Sure Diablo4Companion only scans for the word "damage" when having the damage option activated but it should scan the other damage stats first which should not be displayed to correctly display those affixes that the user has activated.
- The same problem occurs with some "damage reduction" modifiers and also the "movement speed" affixes on boots (where "movement speed for" gets true while only "movement speed" is checked.
Thanks for the feedback. With the current implementation it is not really possible. Because then I would need to scan for all possible affixes. That would make everything really slow.
I'm however working on a version 2 with an improved GUI. I have some ideas to handle those issues then. No promises yet when it's ready. Still a lot to do. Hope to have it ready and tested before season 2.
A workaround I found is by screenshotting my own Affix images as .png from my actual game and replacing the ones located in the preset folder I'm using (..\Images\1080p_SMF_en\Affixes).
For example, for crit dmg, this is how I have my affixes setup in Tooltips for weapons:
And this is my own affix image that I captured, to somehow differentiate it from other similar affixes:
(Notice the extra empty space under the actual affix to differentiate it from other similar affixes or other multi-lined affixes in general)
Unwanted crit dmg:
Also works for movement speed compared to SOME of the other similar movement affixes:
This works by having 'Advanced Tooltip Information' turned on in the settings so that the game adds those extra spaces(for certain affixes that would need to continue to a new line/row) between each affixes.
Unfortunately this workaround just doesn't work for damage reduction. I just ended up excluding 'damage reduction' specifically and included the other damage reductions from the active tooltips.
nice idea! now i will need to make some screenshots 🗡️
Tip to keep in mind when looking for a unique image for an affix. When capturing multiple lines the values in affixes can cause the text to have a small offset. It will no longer match in those cases.
e.g. if you have a affix with +11% or +22% it will move all text slightly to the right.
Tip to keep in mind when looking for a unique image for an affix. When capturing multiple lines the values in affixes can cause the text to have a small offset. It will no longer match in those cases.
e.g. if you have a affix with +11% or +22% it will move all text slightly to the right.
Yeah, I came across this for 'damage reduction from affected...' I ended up uploading 2 different images of the same affix; one image is the affix with a single digit %, and the other with double digit %. The spacing for any X.X% and XX.X% each both seems to be consistent.
Is it possible for the image detecting to convert the affixes found in the Tooltip into a list of strings and have it search for affixes from a dictionary?
I'm assuming this affects the speed and performance drastically?
Is it possible for the image detecting to convert the affixes found in the Tooltip into a list of strings and have it search for affixes from a dictionary?
That is possible and something I'll probably look into later.
One issue is to support all 12 Diablo languages when using OCR to convert affixes to text. With image detecting it will always work for any language.
I'm assuming this affects the speed and performance drastically?
Will have to test that to be sure. But there are two steps that influence the performance:
- The affix image to text conversion.
- The validation part afterwards to match the text with a valid affix.
One issue is to support all 12 Diablo languages when using OCR to convert affixes to text. With image detecting it will always work for any language.
Everyone can freely switch their language to whatever they want... Simply make english the main supported language and whoever wants to use Diablo4Companion needs to switch to english. This should really be no big deal.
For you maybe but not everyone learned English. I'm not going to exclude those users by saying the app no longer support languages other than English.
But let's first focus on version 2.0. When everything is ready the app should be able to support multi-line affixes without using OCR.
Closing this as v2.0 is now available.
Still having this issue with Damage Reduction affixes.
Still having this issue with Damage Reduction affixes.
@Larsy93 Could you create a new issue with some example screenshots?
Then I can probably give some tips on how to solve this with v2.0