jonhoo / inferno

A Rust port of FlameGraph

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unify defaults across CLI and impl Default

jonhoo opened this issue · comments

#52 introduces a lot of default values, and they are duplicated between the impl Default for Options and the CLI StructOpt definitions. We should find a way to declare these as global constants, and then use those in both places. There's been a bunch of discussion of that in #52 (comment), which should provide a good starting point.

As part of this, we should probably introduce a mod flamegraph::defaults that contains them so we don't end up littering the API docs with constants.