Port Optimize FlameGraphs by utilizing CSS and modern JS from FlameGraph

Question

Port Optimize FlameGraphs by utilizing CSS and modern JS from FlameGraph

jbcden opened this issue 5 years ago · comments

This issue is to port brendangregg/FlameGraph#189 to inferno. The original author has consented to us porting their work to this project: #26 (comment).

Jon Gjengset · Answer 1 · Mon Feb 18 2019 07:50:56 GMT+0800 (China Standard Time)

Now that this has been merged upstream too, this should be even easier to land! :D

Jon Gjengset · Answer 2 · Sun Mar 10 2019 13:20:22 GMT+0800 (China Standard Time)

I really want to see this land. @jbcden any chance you might submit a PR for this?

Jacob Chae · Answer 3 · Mon Mar 11 2019 07:59:20 GMT+0800 (China Standard Time)

@jonhoo I can try to get something put together this weekend. I do not think I will have time before then though; does that sound alright?

Jon Gjengset · Answer 4 · Mon Mar 11 2019 09:33:10 GMT+0800 (China Standard Time)

@jbcden that sounds perfect!

Jon Gjengset · Answer 5 · Tue Mar 19 2019 10:40:59 GMT+0800 (China Standard Time)

@jbcden gentle ping on this :)

Jacob Chae · Answer 6 · Tue Mar 19 2019 12:39:32 GMT+0800 (China Standard Time)

@jonhoo Sorry about the delay! I had some personal stuff come up this weekend and have family coming to visit this week. I will try to open something if I get time, but I may not get to it for a couple of weeks. 😞

Jon Gjengset · Answer 7 · Tue Mar 19 2019 21:12:06 GMT+0800 (China Standard Time)

@jbcden No problem at all! Our lives are far more important than some random piece of code on the internet. Enjoy your week+weekend! :D

Jason Hansen · Answer 8 · Fri Mar 22 2019 22:11:00 GMT+0800 (China Standard Time)

@jbcden Last night I was playing around with some of the changes that will be required for this. I could finish it up if you're not already working on it. I don't want to step on your toes. Let me know.