jonhoo / flurry

A port of Java's ConcurrentHashMap to Rust

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add benchmarks

jonhoo opened this issue · comments

We should port the single-core benchmarks from hashbrown, and the concurrent ones from dashmap to measure the performance of flurry!

commented

How do you feel about the dependencies for this? dashmap uses criterion which, according to their docs only works if one disables the default benchmarking harness generated by test. On the contrary, hashbrown uses test and its Bencher. (Also dashmap uses rayon, but since we have #14 this might be added anyway).

Since test::bench is, I believe, still feature-gated and nightly-only, it might be easier to rewrite the hashbrown macros to use criterion, but either way we should probably settle on one solution for all benchmarks.

I'll start with the dashmap benches once this is clear.

I think criterion is the way to go!

commented

Alright! I'll open a PR when I got some code!

commented

This can now be closed as #43 is merged 😊