Implement "standard" map/collection methods
jonhoo opened this issue · comments
This issue tracks the implementation status of various "standard" methods on collections in general and maps in particular that should be added to flurry. Checked boxes have already been "claimed".
If you want to pick up any of these, leave a comment here and/or open a draft PR!
I would like to implement Eq, Index and clear.
@Stupremee How about you do Eq
and Index
first, and then we do clear
in a separate PR afterwards?
I think I can try to implement the Clone
one . Is it ok?
Absolutely, it's all yours!
I will also implement Debug since Index doesnt work atm
I think I can do with_hasher
and with_capacity_and_hasher
also. But I see them as checked already.
@danielSanchezQ Those are already (accidentally) being added in #24
I'd like to take a crack at implementing reserve
.
@soruh all yours!
I can give a try to the retain
method 😄
I took a quick look at drain
and into_iter
in #33, but I'm not sure how correct & efficient what I wrote actually is.
@jonhoo I'd appreciate it if you could mark the drain
and IntoIter
impls as open (maybe with a link to my existing work); I don't really have the time to look into this further at the moment (I'm still open for questions about my initial implementation #33). I'll write another comment if I have the time to work on this and no one already has.
I'm replacing this with #62 now that there's just one item left.