jonhoo / fantoccini

A high-level API for programmatically interacting with web pages through WebDriver.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Cannot set `pageLoadOptions` in capabilities

aaronshim opened this issue · comments

No matter the value provided in cap, it gets overwritten here:

cap.insert("pageLoadStrategy".to_string(), Json::from("normal"));

Should it first check to see that it is not overwriting this value before resetting it? According to the Selenium documentation, normal, eager, and none are all valid values.

Yep, good catch. Thanks for the PR!

Fixed now that #178 has been merged.