window is not defined

Question

window is not defined

zaruda opened this issue 6 years ago · comments

window is not defined while server-side rendered

Will Tonkin · Answer 1 · Thu Dec 20 2018 19:12:38 GMT+0800 (China Standard Time)

surely you need a DOM in order to use this polyfill, what's the use case for it being SS? I'd suggest you don't apply DOM polyfills when rendering server-side

Ilya Zarudny · Answer 2 · Thu Dec 20 2018 21:28:29 GMT+0800 (China Standard Time)

@willtonkin , this polyfill used by another lib which I'm using in my project.
Only one if statement is necessary to handle problems with ssr

Will Tonkin · Answer 3 · Fri Dec 21 2018 01:11:05 GMT+0800 (China Standard Time)

ah, I can see that being annoying. The question then is which project is responsable for being SSR friendly in a chain like that. I'd agree then, this could easily be made to be. I guess it's a question then for the maintainer :)

Jonathan Neal · Answer 4 · Fri Dec 21 2018 01:53:35 GMT+0800 (China Standard Time)

I will do my best to fix this today.

Ilya Zarudny · Answer 5 · Fri Dec 21 2018 02:15:41 GMT+0800 (China Standard Time)

Hi @jonathantneal !
You can check this updates which were made by coreui team today. coreui/coreui-react#53

Jonathan Neal · Answer 6 · Fri Dec 21 2018 02:18:23 GMT+0800 (China Standard Time)

Sorry to have missed their cut off, @zaruda. I’ll still try to resolve this today.