Runtime dependency on pry?

Question

Runtime dependency on pry?

zverok opened this issue 4 years ago · comments

Hey!

While planning to release a gem based on (awesome 😍) ffast, I noticed it pulls pry as its runtime dependency. Is this intended? I don't see any usage of pry in lib/ so it seems it should be rather development depenedency?..

Jônatas Davi Paganini · Answer 1 · Wed May 13 2020 19:59:37 GMT+0800 (China Standard Time)

Hey @zverok ! glad to hear that! I'm going to remove it from runtime because it's only useful in the CLI with --pry to jump into debugging session.

Let me know when you publish the gem ❤️

Jônatas Davi Paganini · Answer 2 · Wed May 13 2020 20:05:26 GMT+0800 (China Standard Time)

Done! 85fdbc6

Also released a new version to make it easy :)

Victor Shepelev · Answer 3 · Wed May 13 2020 20:24:11 GMT+0800 (China Standard Time)

Thanks! 👍
The gem is already released: https://github.com/zverok/the_schema_is
I'll update to the newest fast in the next version :)

Jônatas Davi Paganini · Answer 4 · Wed May 13 2020 21:08:37 GMT+0800 (China Standard Time)

Very cool @zverok! I personally liked the gem idea and the tooling to make it easy to adopt!

Also, the idea of having the ffast method in the AST node is great! I'm adding something similar on #21.