Rename `default` to `defaultImage`
dhilipsiva opened this issue · comments
default is a Javascript Reserved keyword. While this is handled smartly by most browsers, others complain a Parse Error.
Can we start working on version 3.0 and push it? These are critical.
Sure thing 😺
Published to npm as ember-cli-gravatar@2.5.2. I published this as 2.5.2 as it isn't a breaking change. However, for 3.0 I'm wondering if we should rename this property to defaultImage to avoid the keyword altogether.
Closes #21
Yeah, that is why I actually created: #20 (comment) . We should rename it to defaultImage, that sounds better and unambiguous.
Great, got all the related issues into the 3.0 milestone.
3.0.0 is released. Thanks for all your help @dhilipsiva!
Whoa, Great! That was quick. No, thank you for the addon @johnotander 😄