Giters

johnlonganecker / libpostal-rest

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

MODEL=senzing

tomdavidson opened this issue · comments

commented

I'd like to use the senzing model with libpsotal-rest. Looks like it would need its own custom gopostal lib. Interested in supporting the option? I hardly have any go experience but could try a PR? How would you like it to look?

commented

Hmm great question, it seems like you would need to add the MODEL=senzing to this line https://github.com/johnlonganecker/libpostal-rest-docker/blob/master/build_libpostal.sh#L4

I am not in touch with libpostal lately but I do try to help out when/where I can. Is there any downsides to adding this in? IE it will make it not work for some countries?

commented

any downsides to adding this

I dont have data to say one way or another but I assume if its optimized for USA addresses that there was a take for non-USA addresses.

If its just the build script in the docker packaging then I can just bake my own image. I had thought it had been ported to go in gopostal and we needed to make libpostal-rest have an option to import a different lib.