JSMin also brakes the Modernizr and jQuery Placeholder libraries. (v2 beta)

[Sean Delaney]

JSMin also brakes the Modernizr and jQuery Placeholder libraries.

Both errors show:

TypeError: 'undefined' is not a function (near 'blah blah blah')

Sean

[John D Wells Jr]

Hey Sean - just so I'm sure what to test, are you testing the minified or un-minified versions of Modernizr & Placeholder, and which versions of each? And also, is this with JSMin, or JSMinPlus?

I'm going to try some tweaks with JSMinPlus, namely adding a line return between each file minification, and see if that helps.

Thanks for testing!

Cheers,
John

John D Wells
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Saturday, 31 March 2012 at 20:03, Sean Delaney wrote:

JSMin also brakes the Modernizr and jQuery Placeholder libraries.

Both errors show:

TypeError: 'undefined' is not a function (near 'blah blah blah')

Sean

---

Reply to this email directly or view it on GitHub:
#2

[Sean Delaney]

Hi John.

I use the minified versions of both libraries:

Modernizr 2.0.6 (Custom Build)
http://mths.be/placeholder v1.8.6

Happens with JSMin and JSMinPlus. My only guess is that JSMin tries to minify these libraries again.

---

Sean Delaney

On 31 Mar 2012, at 21:21, John D Wells wrote:

Hey Sean - just so I'm sure what to test, are you testing the minified or un-minified versions of Modernizr & Placeholder, and which versions of each? And also, is this with JSMin, or JSMinPlus?

I'm going to try some tweaks with JSMinPlus, namely adding a line return between each file minification, and see if that helps.

Thanks for testing!

Cheers,
John

John D Wells
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Saturday, 31 March 2012 at 20:03, Sean Delaney wrote:

JSMin also brakes the Modernizr and jQuery Placeholder libraries.

Both errors show:

TypeError: 'undefined' is not a function (near 'blah blah blah')

Sean

---

Reply to this email directly or view it on GitHub:
#2

---

Reply to this email directly or view it on GitHub:
#2 (comment)

[John D Wells Jr]

Hi Sean,

Hmm, I'm having trouble reproducing the error. Could you send me a bit of
info on how you're reproducing it, maybe even zip up and send whatever
scripts & usage snippet you have?

Hopefully I can replicate, and then also test against Minimee 1.6x - the
underlying Minify library has been updated since 1x so I'm curious to see
if that's the root cause.

Thanks Sean!
John

On 1 April 2012 10:45, Sean Delaney <
[e-mail]

wrote:

Hi John.

I use the minified versions of both libraries:

Modernizr 2.0.6 (Custom Build)
http://mths.be/placeholder v1.8.6

Happens with JSMin and JSMinPlus. My only guess is that JSMin tries to
minify these libraries again.

---

Sean Delaney

On 31 Mar 2012, at 21:21, John D Wells wrote:

Hey Sean - just so I'm sure what to test, are you testing the minified
or un-minified versions of Modernizr & Placeholder, and which versions of
each? And also, is this with JSMin, or JSMinPlus?

I'm going to try some tweaks with JSMinPlus, namely adding a line return
between each file minification, and see if that helps.

Thanks for testing!

Cheers,
John

John D Wells
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Saturday, 31 March 2012 at 20:03, Sean Delaney wrote:

JSMin also brakes the Modernizr and jQuery Placeholder libraries.

Both errors show:

TypeError: 'undefined' is not a function (near 'blah blah blah')

Sean

---

Reply to this email directly or view it on GitHub:
#2

---

Reply to this email directly or view it on GitHub:
#2 (comment)

---

Reply to this email directly or view it on GitHub:
#2 (comment)

Pura Vida
John D Wells
http://www.johndwells.com

[John D Wells Jr]

Hi Sean,

I'm still unable to reproduce this I'm afraid - would you be willing to email me the modernizr & placeholder versions you were using?

Cheers,
John

[John D Wells Jr]

Hi Sean,

It's an old thread, but I'm closing it as this issue has (finally!) been fixed; Minimee how separates each JS minified file with a semicolon, which prevents this error.

Cheers,
John