johnbillion / query-monitor

The developer tools panel for WordPress

Home Page:https://querymonitor.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Integration tests are not running

johnbillion opened this issue · comments

The integration tests are not running, both locally and on GitHub Actions CI. When running composer test:integration:

  • The command succeeds but the Codeception tests have not actually run
  • The exit code is 0

This may be related to the PTS allocation, not sure.

Items to investigate:

  • Were the integration tests running successfully before switching to plugin-infrastructure?
  • Does the codeception executable actually get run inside the container?
  • If so, at what step does Codeception exit?
  • Why isn't a non-zero exit code being triggered?
  • Was there a Codeception or wpbrowser update recently?

We've got several layers to contend with. When running composer test:integration:

  1. Composer calls the vendor/bin/integration-tests shell file
  2. This calls the vendor/johnbillion/plugin-infrastructure/bin/integration-tests shell file
  3. This calls docker-compose exec
  4. This calls vendor/bin/codecept in the container
  • Calling ./vendor/bin/integration-tests yields the same result
  • Calling ./vendor/johnbillion/plugin-infrastructure/bin/integration-tests yields the same result

Oh dear. Checking out db9f20a (commit prior to switching to plugin-infrastructure) and running the integration tests works as expected.