Aggregated Log Output

Question

Aggregated Log Output

eloisetaylor5693 opened this issue 5 years ago · comments

I'm submitting a ...

bug report
feature request

What is the current behavior?
When using the brief reporter, none of the output is aggregated. It showed the output for 1 of the 6 exectuters, not all

I tried the option: aggregatedReporterTest: [(reporter)=>regex=/coverage|brief|istanbul|junit/i]

And other permutations of the reporter name

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?
All output should be aggregated, so that I can see the end result for ALL instances

Please tell us about your environment:

version:
"karma-parallel": "^0.3.1",
"karma-brief-reporter": "0.0.7",
Browser: [ Chrome XX ]
Language: [TypeScript X.X | ES6/7 ]
Node v10.15.3
NPM v6.4.1

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Karma Config I was using

module.exports = function (config) {
    config.set({
        basePath: "",
        frameworks: ["parallel", "jasmine", "@angular-devkit/build-angular"],
        plugins: [
            require("karma-jasmine"),
            require("karma-chrome-launcher"),
            require("karma-brief-reporter"),
            require("@angular-devkit/build-angular/plugins/karma"),
            require("karma-parallel")
        ],
        reporters: ["brief"],
        port: 1234,
        colors: true,
        logLevel: config.LOG_WARN,
        autoWatch: true,
        browsers: ["ChromeHeadless"],
        singleRun: false,

        parallelOptions: {
            executors: (Math.ceil(require('os').cpus().length / 2)),
            shardStrategy: 'round-robin',
            aggregatedReporterTest: [(reporter)=>regex=/coverage|brief|istanbul|junit/i]
        },

        briefReporter: {
            suppressBrowserLogs: true
        }
    });
};

Joel Jeske · Answer 1 · Fri May 10 2019 20:19:52 GMT+0800 (China Standard Time)

You are setting the option incorrectly. It should be a function or regex. Try this

aggregatedReporterTest: /coverage|brief|istanbul|junit/i

Eloise · Answer 2 · Fri May 10 2019 21:15:46 GMT+0800 (China Standard Time)

That doesn't work either. I get this error:

  NaN pending  10 05 2019 14:13:31.289:ERROR [karma-server]: TypeError: Cannot read property 'toString' of undefined
    at padNumber (C:\git\angularWebApp\node_modules\karma-brief-reporter\lib\util\printers.js:7:21)
    at printStats (C:\git\angularWebApp\node_modules\karma-brief-reporter\lib\util\printers.js:13:19)
    at Object.exports.printProgress (C:\git\angularWebApp\node_modules\karma-brief-reporter\lib\util\printers.js:28:3)
    at Brief.onSpecComplete (C:\git\angularWebApp\node_modules\karma-brief-reporter\lib\brief.js:45:16)
    at reporters.forEach (C:\git\angularWebApp\node_modules\karma-parallel\lib\reporter.js:61:26)
    at Array.forEach (<anonymous>)
    at AggregatedCoverageReporter._.rest (C:\git\angularWebApp\node_modules\karma-parallel\lib\reporter.js:58:15)
    at apply (C:\git\angularWebApp\node_modules\lodash\lodash.js:475:27)
    at C:\git\angularWebApp\node_modules\lodash\lodash.js:6569:16
    at AggregatedCoverageReporter.onSpecComplete (C:\git\angularWebApp\node_modules\karma-parallel\lib\reporter.js:121:7)
    at Server.<anonymous> (C:\git\angularWebApp\node_modules\karma\lib\events.js:40:26)
    at Server.emit (events.js:194:15)
    at Browser.onResult (C:\git\angularWebApp\node_modules\karma\lib\browser.js:164:20)
    at Socket.socket.on (C:\git\angularWebApp\node_modules\karma\lib\browser.js:214:42)
    at Socket.emit (events.js:189:13)
    at C:\git\angularWebApp\node_modules\socket.io\lib\socket.js:528:12
Cannot read property 'success' of undefined
TypeError: Cannot read property 'success' of undefined
    at TestCommand.runSingleTarget (C:\git\angularWebApp\node_modules\@angular\cli\models\packages\angular\cli\models\architect-command.ts:242:21)
    at process._tickCallback (internal/process/next_tick.js:68:7)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! now@0.0.0 test-fast: `ng test --sourceMap=false --karmaConfig=src/karma.conf.fast.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the now@0.0.0 test-fast script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Eloise · Answer 3 · Tue Jun 18 2019 21:48:05 GMT+0800 (China Standard Time)

Any other suggestions on how to resolve?

Vikas Bhati · Answer 4 · Tue Sep 01 2020 17:55:21 GMT+0800 (China Standard Time)

Hi Joel,
I am also looking for help to get the code coverage (aggregated one) using karma-parallel. Kindly share sample karma.conf.js. Thanks in advance!!

JSchn · Answer 5 · Tue Sep 21 2021 18:55:54 GMT+0800 (China Standard Time)

We had similar issues using istanbul reporter. I got it working by adjusting lib/reporter.js:

--- a/lib/reporter.js
+++ b/lib/reporter.js
@@ -106,11 +106,8 @@ const AggregatedCoverageReporter = function(injector, logger, config, baseReport
 
     delete aggregate.alias.lastResult._realLastResults[browser.id];
     aggregate.real[browser.id] = UNSTARTED;
-
-    // Call through on the very first browser start
-    if (getStartedBrowserCount(aggregate) === 1) {
-      callThrough('onBrowserStart', aggregate.alias);
-    }
+     
+    callThrough('onBrowserStart', aggregate.alias);
   };
    this.onSpecComplete = function (browser, result) {

would be nice if anybody could explain me the reason for the if-condition.

MikeDabrowski · Answer 6 · Thu Oct 20 2022 03:22:01 GMT+0800 (China Standard Time)

I ended up adding this getters to the AggegatedBrowserLastResult. No need to comment out the if below. I wonder how best to proceed with the changes.

  get success() {
    return _.sum(
      _.map(this._realLastResults, 'success')
    )
  }
  get skipped() {
    return _.sum(
      _.map(this._realLastResults, 'skipped')
    )
  }

@jo-soft How did you override the lib inside of your project ?

JSchn · Answer 7 · Mon Jan 09 2023 03:10:54 GMT+0800 (China Standard Time)

@MikeDabrowski basically creating a local fork and adjusting it (after testing it by adjusting local node_modules). but it look like you figured out something

MikeDabrowski · Answer 8 · Mon Jan 09 2023 04:37:02 GMT+0800 (China Standard Time)

I just copied relevant files and imported them locally. Which forced me to pull lodash into my code base. I tried substituting it with ramda (which we use and prefer) at first but there is quite a lot mutation inside and I was not able to replace all of it. I wonder if any other way is possible ?

JSchn · Answer 9 · Tue Mar 21 2023 17:11:42 GMT+0800 (China Standard Time)

it's easy to avoid lodash:

get success() {
    return _.sum(
      _realLastResults.map( result => result.success )
    )
  }
  get skipped() {
    return _.sum(
      _realLastResults.map( result => result.skipped )
    )
  }

MikeDabrowski · Answer 10 · Wed Apr 12 2023 15:39:05 GMT+0800 (China Standard Time)

it's easy to avoid lodash

in some places, yes.

get total() {
  return R.sum(Object.values(this._realLastResults).map(R.prop('total')));
}
get failed() {
  return R.sum(Object.values(this._realLastResults).map(R.prop('failed')));
}
get success() {
  return R.sum(Object.values(this._realLastResults).map(R.prop('success')));
}
get skipped() {
  return R.sum(Object.values(this._realLastResults).map(R.prop('skipped')));
}
get netTime() {
  return R.apply(
    Math.max,
    Object.values(this._realLastResults).map(R.prop('netTime')),
  );
}

But there is this piece for example:

const callThrough = _.rest((fnName, args) => {
  reporters.forEach(({name, reporter}) => {
    if (_.isFunction(reporter[fnName])) {
      log.debug(`relaying ${fnName}() on reporter:${name}`);
      reporter[fnName].apply(reporter, args);
    }
  });
});

I am sure it is possible to use ramda / native-js for this but I just did not want to invest more time in it.

Lodash's functions that are still used: rest, chain, size, extendWith, isFunction, map