joelbutcher / socialstream

OAuth for Laravel, simplified.

Home Page:https://docs.socialstream.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

hardcoded to redirect to /dashboard if laravel breeze

Supernova3339 opened this issue · comments

Stack

Breeze – Blade with Alpine

Package Version

v5.0.3

Laravel Version

v10.38.2

Livewire Version

v3.3.3

react Version

No response

Vue Version

No response

PHP Version

PHP 8.2.0

Problem description

socialstream/src/Actions
/AuthenticateOAuthCallback.php

the redirect route is hardcoded to 'dashboard' instead of RouteServiceProvider::HOME

Expected behavior

redirects to the route specified, eg RouteServiceProvider::HOME route

would also be nice if it can utilize the feature used with registration that redirects to the previous route optionally

Steps to reproduce

try to login with laravel breeze without a dashboard route, throws a 404.

1: install laravel
2: install socialstream
3: set stack to breeze, blade with alpine
4: remove dashboard route
5: bug occurs

Reproduction repository

https://github.com/Supernova3339/ssreprodbug1

Relevant log output

No response

Hey 👋🏻

Thanks for raising an issue with my package. Unfortunately I was unable to locate your reproduction repository. In order to save time and help me identify the issue at hand, please update your issue report with a VALID reproduction repository URL.

When this has been done, please "at" me - this will send an alert to my GitHub notification feed and let me know this issue is ready for further investigation.

Thanks!

Hey 👋🏻

Thanks for raising an issue with my package. Unfortunately I was unable to locate your reproduction repository. In order to save time and help me identify the issue at hand, please update your issue report with a VALID reproduction repository URL.

When this has been done, please "at" me - this will send an alert to my GitHub notification feed and let me know this issue is ready for further investigation.

Thanks!

@joelbutcher I've added a reproduction repository per your request.

@Supernova3339 Please test the mentioned PR (#325) and see if this resolves the problem for you.

@Supernova3339 Please test the mentioned PR (#325) and see if this resolves the problem for you.

gave it a go, works perfectly 🎉