joelbutcher / socialstream

OAuth for Laravel, simplified.

Home Page:https://docs.socialstream.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Maybe not enforce fully qualified user return type in CreatesUserFromProvider contract?

inmanturbo opened this issue · comments

Should this contract enforce App\Models\User in return type? This make the contract unusable if the user model is moved. It would force someone for instance with an App\Models\Auth namespace to maybe stub out an abstract user class in the App\Models namespace just to satisfy the contract. Just a thought.

public function create(string $provider, ProviderUserContract $providerUser): User;

Resolved in v4.0.1